fix: detect server subfolder in init #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
previously approved these changes
Oct 3, 2025
|
Thanks! Are you able to fix the merge conflicts and we can get this shipped 🚀 |
MaxKless
force-pushed
the
detect-subfolder-in-init
branch
from
7a3e409 to
514c92d
Compare
|
awesome, glad to hear it @domdomegg! I rebased and fixed the merge conflicts :) |
rdimitrov
reviewed
Oct 6, 2025
cmd/publisher/commands/init.go
Outdated
| // If we're in a subdirectory, use the current folder name | ||
| if subfolder != "" { | ||
| if cwd, err := os.Getwd(); err == nil { | ||
| folderName := filepath.Base(cwd) |
There was a problem hiding this comment.
It seems we use subfolder as a boolean even though it's a string. Wouldn't it be better to reuse the subfolder variable we already have?
For example if it's != "" construct the path using it (and avoid reading the base path again), otherwise proceed as if we are in the root repo.
There was a problem hiding this comment.
you're completely right, I pushed a fix
|
Hey! Any update on this? Looks like I got an approval and fixed the comment from the other review so is it ready to be merged? |
domdomegg
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Discussion from this issue: #538
We want to make it clearer that repo name & server name do not HAVE to be the same, especially in monorepos.
@tadasant this seems like a minor thing that doesn't have to be documented specifically, lmk if you disagree :)
How Has This Been Tested?
Tested the init flow locally, running the built
initcommand from a subfolder and the repo root.Breaking Changes
No
Types of changes
Checklist
Additional context